Skip to content

Fix PieChart to be able to be rendered#100

Merged
Hermanya merged 1 commit into
chart-kit:masterfrom
k-yokoishi:fix/broken-rendering-by-innter-text
Mar 31, 2019
Merged

Fix PieChart to be able to be rendered#100
Hermanya merged 1 commit into
chart-kit:masterfrom
k-yokoishi:fix/broken-rendering-by-innter-text

Conversation

@k-yokoishi

Copy link
Copy Markdown
Contributor

In v2.4.0, when running yarn start, App.js doesn't render anything without any error, so I fix this problem with this MR.

However, I couldn't find any related issue. If you could reproduce this problem by running yarn start in v2.4.0, please make sure that this problem can be solved by this MR?

The environment where the problem was found is as follows.

  • OS: OSX 10.14.3
  • expo: 2.13.0
  • Xcode: 10.1
  • Simulator: iOS 12.1, iPhone 8
  • Node: v8.10.0

@Hermanya

Copy link
Copy Markdown
Contributor

I cannot reproduce this error with my set up, but the fix looks good to me. Thanks 👍

@Hermanya Hermanya merged commit 9136323 into chart-kit:master Mar 31, 2019
@k-yokoishi k-yokoishi deleted the fix/broken-rendering-by-innter-text branch March 31, 2019 14:18
@Hermanya

Copy link
Copy Markdown
Contributor

available in v2.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants